feat(website): add topbar and user dialog docs #3249
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
Area: Components
✅ Deploy Preview for paste-theme-designer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for paste-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2118acf:
|
Passing run #6144 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
|||||||||||||||
|
Size Change: +13 B (0%) Total Size: 1.01 MB
ℹ️ View Unchanged
|
github-actions
bot
removed
the
Area: Components
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d4bb99c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
TheSisb
reviewed
Jun 1, 2023
| {account} | ||
| </MenuBadge> | ||
| <Menu {...menu} aria-label="Accounts"> | ||
| <MenuItem {...menu} onClick={()=>onClick('Account one')}> |
There was a problem hiding this comment.
suggestion (blocking): let's update the onClick so that it actually updates account state, so it works when clicking through the demo
There was a problem hiding this comment.
the onClick uses setAccount to update the account state. what should be updated?
serifluous
requested changes
Jun 2, 2023
serifluous
reviewed
Jun 7, 2023
serifluous
reviewed
Jun 7, 2023
serifluous
reviewed
Jun 7, 2023
github-actions
bot
added
the
Area: Components
serifluous
requested changes
Jun 13, 2023
| <Input placeholder="Search" insertBefore={<SearchIcon decorative/>}/> | ||
| </Box> | ||
| <ProductSwitcherButton {...productSwitcher} i18nButtonLabel="Switch products" /> | ||
| <ProductSwitcher {...productSwitcher} aria-label="Avaiable accounts"> |
There was a problem hiding this comment.
issue: The badges are stretched in the example
| - [User Dialog](#user-dialog) | ||
| - [Product Switcher](/components/product-switcher) | ||
|
|
||
| ## Default Topbar |
There was a problem hiding this comment.
thought(non-blocking): Something about how there's a lot of repeated content between the "About Topbar" and "Default Topbar" sections bothers me, but I'll just wait til User Dialog is done and review the full page content.
serifluous
reviewed
Jun 27, 2023
serifluous
previously approved these changes
Jun 27, 2023
nkrantz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.